reduce common directory #1948
Merged
reduce common directory #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0 (apache#1929) Bumps [github.com/emicklei/go-restful/v3](https://github.com/emicklei/go-restful) from 3.7.4 to 3.8.0. - [Release notes](https://github.com/emicklei/go-restful/releases) - [Changelog](https://github.com/emicklei/go-restful/blob/v3/CHANGES.md) - [Commits](emicklei/go-restful@v3.7.4...v3.8.0) --- updated-dependencies: - dependency-name: github.com/emicklei/go-restful/v3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AlexStocks
reviewed
Jul 1, 2022
AlexStocks
approved these changes
Jul 4, 2022
AlexStocks
reviewed
Jul 4, 2022
xds/resolver/watch_service.go
Outdated
| @@ -30,7 +30,10 @@ import ( | |||
| ) | |||
|
|
|||
| import ( | |||
| dubboLogger "dubbo.apache.org/dubbo-go/v3/common/logger" | |||
| dubboLogger "github.com/dubbogo/gost/log/logger" | |||
There was a problem hiding this comment.
pls rename its name to 'dubbogoLogger'. pls change all codes in other places.
|
pls fix the confliction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
reduce common directory
Which issue(s) this PR fixes:
Fixes # #1937
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed